YETUS-1073. GITHUB_REPO_DEFAULT isn't honored#199
Merged
aw-was-here merged 1 commit intoapache:mainfrom Nov 10, 2020
Merged
Conversation
busbey
approved these changes
Nov 10, 2020
Contributor
busbey
left a comment
There was a problem hiding this comment.
nit: a better commit subject would be something like "github plugin initialization should honor GITHUB_REPO_DEFUALT"
So that it's talking about what happens with the change rather than what happens before it.
8d42cb8 to
5b1db03
Compare
Contributor
Author
|
Thanks! |
aw-was-here
added a commit
to effectivemachines/buretoolbox
that referenced
this pull request
Nov 16, 2020
Signed-off-by: Sean Busbey <busbey@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.